🐛🎨 [Frontend] RTC: Reload project after websocket reconnection #8406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures users are automatically added to socket rooms for projects they have open when connecting, improving real-time collaboration and state synchronization across project sessions.
odeimaiz
changed the title
odeimaiz
added
t:enhancement
odeimaiz
changed the title
🧪 CI InsightsHere's what we observed from your CI run for 111fb5b. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Pull Request Overview
Adds a Share button to the study menu and improves WebSocket reconnection handling by reloading project data after reconnections to ensure data consistency. Also enhances error handling for pipeline runs by displaying backend error messages.
- Adds Share button to study menu that opens access rights management
- Implements project document re-synchronization on WebSocket reconnections
- Improves error message handling for 409 status pipeline run errors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| StudyTitleWOptions.js | Adds Share menu button and access rights functionality |
| StudyEditor.js | Adds WebSocket reconnection handling and improves pipeline error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js
Show resolved
Hide resolved
…tudyEditor.js Co-authored-by: Copilot <[email protected]>
…b.com:matusdrobuliak66/osparc-simcore into fixes/rtc-2
odeimaiz
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8406 +/- ##
==========================================
- Coverage 87.90% 81.19% -6.72%
==========================================
Files 1951 761 -1190
Lines 75967 35050 -40917
Branches 1336 175 -1161
==========================================
- Hits 66778 28458 -38320
+ Misses 8790 6535 -2255
+ Partials 399 57 -342
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
matusdrobuliak66
approved these changes
Sep 23, 2025
|
@mergify queue |
🟠 Waiting for conditions to match
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR improves WebSocket reconnection handling by reloading project data after reconnections to ensure data consistency.
In the animation, user1 goes offline while user2 added the sleeper_3 node. After reconnecting, user1 fetches the latest project and adds the missing sleeper_3.
Bonus:
Related issue/s
How to test
Dev-ops